feat: fetch precompiled xk6 extension from grafana/xk6-sm
#966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
xk6-sm-repo
branch
5 times, most recently
from
22c0782 to
b932ad2
Compare
nadiamoe
force-pushed
the
xk6-sm-repo
branch
14 times, most recently
from
a87160d to
26f8d91
Compare
nadiamoe
changed the title
grafana/xk6-smgrafana/xk6-sm
This was referenced Nov 25, 2024
nadiamoe
force-pushed
the
xk6-sm-repo
branch
from
26f8d91 to
0c22da7
Compare
nadiamoe
force-pushed
the
xk6-sm-repo
branch
from
0c22da7 to
55e7688
Compare
|
Drone CI fails as it is going to be decommissioned soon, and agreed with @mem that it is not worth maintaining. |
|
@roobre rebase, please? |
nadiamoe
force-pushed
the
xk6-sm-repo
branch
from
55e7688 to
ec6b043
Compare
|
@mem Rebased! |
nadiamoe
changed the title
grafana/xk6-smgrafana/xk6-sm
nadiamoe
changed the title
grafana/xk6-smgrafana/xk6-sm
mem
approved these changes
Dec 16, 2024
nadiamoe
changed the title
grafana/xk6-smgrafana/xk6-sm
|
|
nadiamoe
changed the title
grafana/xk6-smgrafana/xk6-sm
mem
approved these changes
Jan 23, 2025
Merged
nadiamoe
added a commit
that referenced
this pull request
Feb 6, 2025
This should have been done as part of #966, but somehow slipped through the cracks.
nadiamoe
added a commit
that referenced
this pull request
Feb 6, 2025
This should have been done as part of #966, but somehow slipped through the cracks.
nadiamoe
added a commit
that referenced
this pull request
Feb 6, 2025
This should have been done as part of #966, but somehow slipped through the cracks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
smextension code from this repo and adjust Makefiles and Dockerfiles to pull k6 from https://github.com/grafana/xk6-sm.A bullet-point summary
$(DISTDIR)/$(OS)-$(ARCH)/sm-k6targets have been added tocurlk6 from grafana/xk6-sm releasessm-k6-nativeis a convenient alias for the host's OS/ARCH, whilesm-k6downloads sm-k6 for all known architecturestestorpackagetargets. They can be, but as the package target does not depend on build, I followed that pattern.make sm-k6is manually invoked in the pipeline.I've bothered to make goreleaser work with this, just to have drone not fail while we get to remove it. For that, thebuildtarget needs to depend onsm-k6-native. If we decide to not keep dependencies, we can remove this when we ditch goreleaser (details on why this was needed are on a comment).Part of https://github.com/grafana/synthetic-monitoring/issues/160